Gangams/aad stage2 full switch to mdsd#559

Merged

ganga1980 merged 20 commits into

gangams/aad-stage2-full-switch-to-mdsd

May 22, 2021

ganga1980 commented May 17, 2021

Contributor

This PR has following changes

conversion of all fluentd plugins to v1 version
upgrade to ruby version 2.6
routing all the CI data types to Linux AMA
Linux AMA official release with all the changes
removal of the omsagent dependency
kept hidden fall back option to direct ODS ingestion as v1 for the container log data type for Linux agent
tag names on the out plugins changed to inline aad auth changes related to tag from extension config.
Note -> no changes in omsagent.yaml related to fluentd config to keep ability to switch image tag if required. plan to update this in subsequent releases.

Pending items

bug bash, fixes for the bugs if there are any during bug bash
Scale testing and results with current agent vs released candidate

ganga1980 added 11 commits

May 13, 2021 20:25


          full switch to mdsd, upgrade to ruby v1 & omsagent removal

df13606


          add odsdirect as fallback option

9edf933


          cleanup

bbecc2c


          cleanup

836331a


          move customRegion to stage3


          updates related to containerlog route

f29ec25


          make xml eventschema consistent

f3fbf3c


          add buffer settings

673807f


          address HTTPServerException deprecation in ruby 2.6

877ae9e


          update to official mdsd version

90e9eeb


          fix log message issue

7ecdbab

ganga1980 requested review from a team and joby-thomas

May 17, 2021 23:31

vishiy reviewed

View reviewed changes

build/common/installer/scripts/tomlparser.rb

vishiy reviewed

View reviewed changes

build/common/installer/scripts/tomlparser.rb

vishiy reviewed

View reviewed changes

source/plugins/utils/oms_common.rb

vishiy reviewed

View reviewed changes

build/linux/installer/conf/container.conf

vishiy reviewed

View reviewed changes

build/linux/installer/datafiles/base_container.data

vishiy reviewed

View reviewed changes

kubernetes/linux/setup.sh

vishiy reviewed

View reviewed changes

source/plugins/go/src/oms.go

vishiy reviewed

View reviewed changes

source/plugins/go/src/oms.go

vishiy reviewed

View reviewed changes

source/plugins/go/src/telemetry.go

vishiy reviewed

View reviewed changes

source/plugins/go/src/utils.go Outdated

vishiy reviewed

View reviewed changes

source/plugins/go/src/utils.go Outdated

vishiy reviewed

View reviewed changes

source/plugins/ruby/in_kube_nodes.rb

vishiy reviewed

View reviewed changes

source/plugins/ruby/in_win_cadvisor_perf.rb

vishiy reviewed

View reviewed changes

source/plugins/ruby/in_kube_pvinventory.rb Outdated

vishiy reviewed

View reviewed changes

source/plugins/ruby/out_mdm.rb Outdated

vishiy reviewed

View reviewed changes

build/linux/installer/conf/container.conf

vishiy reviewed

View reviewed changes

build/linux/installer/conf/kube.conf

gracewehner commented May 18, 2021

Contributor

Hi Ganga, how do we update the ruby gems? I ran a trivy scan for cidev:cioneagent05172021-1 and still see these flagged:

ganga1980 commented

View reviewed changes

ganga1980 left a comment •

edited

Loading

Contributor Author

Hi Ganga, how do we update the ruby gems? I ran a trivy scan for cidev:cioneagent05172021-1 and still see these flagged:

ruby gem installed through gem install as i showed you. since the vulns are in http_parser so I looked at the http_parser gem https://rubygems.org/gems/http_parser.rb/versions to see if we can upgrade to latest version, but version we are using (meaning come with ruby 2.6) is latest version and also there is an active issue tmm1/http_parser.rb#66 for the same vulnerabilities what you pointed out here. I think, we will have to wait until new version of the http_parser available. let me know if we need to reach security team to update on this.

ganga1980 added 8 commits

May 18, 2021 21:43


          fix pr feedback

5cd47d7


          get ridoff unused code from omscommon

a4dff09


          fix pr feedback

2c8afa4


          fix pr feedback

7b94989


          merge ci_dev latest changes

1e148d1


          clean up

b2fb9d8


          clean up

a1c7658


          Merge branch 'ci_dev' into gangams/aad-stage2-full-switch-to-mdsd

df4898a

rashmichandrashekar reviewed

View reviewed changes

build/linux/installer/datafiles/base_container.data


          fix missing conf

d1de167

ganga1980 requested review from rashmichandrashekar and vishiy

May 21, 2021 22:17

daweim0 approved these changes

View reviewed changes

kubernetes/linux/setup.sh

ganga1980 merged commit c707539 into ci_dev

ganga1980 mentioned this pull request

emit log entries when more than 0 after exclusion #618

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

Labels

None yet